fix(#45): structural batching uses device qubit count for non-overlapping placement - #97
Merged
Merged
Conversation
…ping placement _structural_batch used set(range(circuit.num_qubits)) to track qubit usage, making any two same-size circuits always overlap. On a 127-qubit device, four 3-qubit circuits should batch together. Fix: Track cumulative qubit count against max_qubits instead of checking virtual qubit set overlap. Circuits are now batched as long as total qubits fit within the device capacity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes structural batching to use device qubit count (max_qubits) instead of virtual qubit set overlap. Circuits of the same size can now be batched together on large devices. 3 regression tests added. All 337 tests pass.